Bump neo4j driver / Improve connection handling in CLI #3218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aiting to connect
Hoping this fixes `dropDb()` functionality which is called on shutdown.
CarsonF
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is felt in CLI (console/REPL), where a command could finish before DB connection is created or needed. This is also exacerbated by the fact that sometimes the socket connection doesn't emit data (from server, though I'm not convinced it's an actual server problem) in these short windows. So the driver is left waiting for a successful response to a
logoncommand, but it never shows up.waitForRootUserId()Like the above, if the retry loop is a timed out waiting state, don't let that block the process from closing.
This will be released in 5.21 tomorrow(?) but applying now since we are sensitive to this.
Now multiple calls asking for this (or using this to "wait for successful connection"), will share a single underlying promise. If the promise is successful, it will be cached for 3 minutes.